Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D4CA7709 for ; Thu, 3 Nov 2011 20:15:57 +0000 (UTC) Received: (qmail 80708 invoked by uid 500); 3 Nov 2011 20:15:56 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 80681 invoked by uid 500); 3 Nov 2011 20:15:56 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 80644 invoked by uid 99); 3 Nov 2011 20:15:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 20:15:56 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 20:15:53 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 19C06330E2A for ; Thu, 3 Nov 2011 20:15:33 +0000 (UTC) Date: Thu, 3 Nov 2011 20:15:33 +0000 (UTC) From: "Eli Collins (Closed) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1420423285.57196.1320351333106.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2089418375.47092.1313623107214.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Closed] (HADOOP-7551) LocalDirAllocator should incorporate LocalStorage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Collins closed HADOOP-7551. ------------------------------- > LocalDirAllocator should incorporate LocalStorage > ------------------------------------------------- > > Key: HADOOP-7551 > URL: https://issues.apache.org/jira/browse/HADOOP-7551 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 0.20.204.0 > Reporter: Eli Collins > > The o.a.h.fs.LocalDirAllocator is not aware of o.a.h.m.t.LocalStorage (introduced in MAPREDUCE-2413) - it always considers the configured local dirs, not just the ones that happen to be good. Therefore if there's a disk failure then *every* call to get a local path will result in LocalDirAllocator#confChanged doing a disk check of *all* the configured local dirs. It seems like LocalStorage should be a private class to LocalAllocator so that all users of LocalDirAllocator benefit from the disk failure handling and all the various users of LocalDirAllocator don't have to be modified to handle disk failures. Note that LocalDirAllocator already handles faulty directories. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira