Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Mon, 28 Nov 2011 21:51:40 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1011361768.19742.1322517100127.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1133748281.34969.1308871367581.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7424) Log an error if the topology
 script doesn't handle multiple args
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158817#comment-13158817 ] 

Hudson commented on HADOOP-7424:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1355 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1355/])
    HADOOP-7863: apply HADOOP-7424 to 0.23.1

stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1207614
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

                
> Log an error if the topology script doesn't handle multiple args
> ----------------------------------------------------------------
>
>                 Key: HADOOP-7424
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7424
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Uma Maheswara Rao G
>              Labels: newbie
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7424.patch
>
>
> ScriptBasedMapping#resolve currently warns and returns null if it passes n arguments to the topology script and gets back a different number of resolutions. This indicates a bug in the topology script (or it's input) and therefore should be an error.
> {code}
> // invalid number of entries returned by the script
> LOG.warn("Script " + scriptName + " returned "
>    + Integer.toString(m.size()) + " values when "
>    + Integer.toString(names.size()) + " were expected.");
> return null;
> {code}
> There's only one place in Hadoop (FSNamesystem init) where we pass multiple arguments to the topology script, and it only done for performance (to trigger resolution/caching of all the hosts in the includes file on startup). So currently a topology script that doesn't handle multiple arguments just means the initial cache population doesn't work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira