hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7851) Configuration.getClasses() never returns the default value.
Date Thu, 24 Nov 2011 18:02:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156851#comment-13156851
] 

Uma Maheswara Rao G commented on HADOOP-7851:
---------------------------------------------

{quote}
Can we not test instead for an empty array and return the default value? This way we properly
reuse the getTrimmedStrings function thats already present, instead of directly calling out
the StringUtils one.
{quote}
This also should work.

{quote}
This problem exists in 0.20-security as well. Would love it if you can post a patch for that
as well?
{quote}

In 20Security205, getStrings itself will return null if collection is empty.

Collection<String> values = getStringCollection(str);
    if(values.size() == 0) {
      return null;
    } 

I dont see problem here. Am i missing some thing here?
                
> Configuration.getClasses() never returns the default value.
> -----------------------------------------------------------
>
>                 Key: HADOOP-7851
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7851
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Amar Kamat
>            Assignee: Uma Maheswara Rao G
>              Labels: configuration
>             Fix For: 0.24.0, 0.23.1
>
>         Attachments: HADOOP-7851.patch
>
>
> Configuration.getClasses() never returns the default value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message