hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7786) Remove HDFS-specific configuration keys defined in FsConfig
Date Tue, 01 Nov 2011 01:33:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140782#comment-13140782
] 

Hadoop QA commented on HADOOP-7786:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501710/hadoop-7786-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/347//console

This message is automatically generated.
                
> Remove HDFS-specific configuration keys defined in FsConfig
> -----------------------------------------------------------
>
>                 Key: HADOOP-7786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7786
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.21.1
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: HDFS-1900.txt, hadoop-7786-1.patch
>
>
> HADOOP-4952 added a couple HDFS-specific configuration values to common (the block size
and the replication factor) that conflict with the HDFS values (eg have the wrong defaults,
wrong key name), are not used by common or hdfs and should be removed. After removing these
I noticed the rest of FsConfig is only used once outside a test, and isn't tagged as a public
API, I think we can remove it entirely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message