hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7833) Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
Date Fri, 18 Nov 2011 21:56:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153158#comment-13153158
] 

Suresh Srinivas commented on HADOOP-7833:
-----------------------------------------

John, thanks for doing this. The warnings were introduced by me :-)

Can you remove the previous section, where I had tried to suppress these warnings (that did
not work).
                
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7833
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7833
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: John Lee
>            Priority: Blocker
>         Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated
class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable
class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> +    <Match>
> +      <!-- protobuf generated code -->
> +      <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> +    </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message