Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4F859B83 for ; Mon, 31 Oct 2011 21:53:56 +0000 (UTC) Received: (qmail 18448 invoked by uid 500); 31 Oct 2011 21:53:56 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 18382 invoked by uid 500); 31 Oct 2011 21:53:56 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 18374 invoked by uid 99); 31 Oct 2011 21:53:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 21:53:56 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 21:53:54 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5D14D32BB72 for ; Mon, 31 Oct 2011 21:53:33 +0000 (UTC) Date: Mon, 31 Oct 2011 21:53:33 +0000 (UTC) From: "Hadoop QA (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <940570113.42870.1320098013382.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1409338850.42772.1320096932712.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7785) Add equals, hashcode, toString to DataChecksum MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140600#comment-13140600 ] Hadoop QA commented on HADOOP-7785: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501682/hadoop-7785.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/344//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/344//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/344//console This message is automatically generated. > Add equals, hashcode, toString to DataChecksum > ---------------------------------------------- > > Key: HADOOP-7785 > URL: https://issues.apache.org/jira/browse/HADOOP-7785 > Project: Hadoop Common > Issue Type: Improvement > Components: io, util > Affects Versions: 0.23.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hadoop-7785.txt > > > Simple patch to add these functions to the DataChecksum interface. This is handy for the sake of HDFS-2130. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira