Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 12 Oct 2011 03:17:13 +0000 (UTC)
From: "Harsh J (Assigned) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <913213156.3539.1318389433057.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Assigned] (HADOOP-6490) Path.normalize should use
 StringUtils.replace in favor of String.replace
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J reassigned HADOOP-6490:
-------------------------------

    Assignee: Uma Maheswara Rao G

+1. TestPath passes with all its existing Normalization tests. Pushing.
                
> Path.normalize should use StringUtils.replace in favor of String.replace
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-6490
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6490
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-6490.patch
>
>
> in our environment, we are seeing that the JobClient is going out of memory because Path.normalizePath(String) is called several tens of thousands of times, and each time it calls "String.replace" twice.
> java.lang.String.replace compiles a regex to do the job which is very costly.
> We should use org.apache.commons.lang.StringUtils.replace which is much faster and consumes almost no extra memory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira