Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D81B29B17 for ; Wed, 5 Oct 2011 16:15:04 +0000 (UTC) Received: (qmail 79876 invoked by uid 500); 5 Oct 2011 16:15:04 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 79841 invoked by uid 500); 5 Oct 2011 16:15:04 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 79833 invoked by uid 99); 5 Oct 2011 16:15:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 16:15:04 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 16:15:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 5C7602AA7C2 for ; Wed, 5 Oct 2011 16:14:40 +0000 (UTC) Date: Wed, 5 Oct 2011 16:14:40 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <2035699652.12354.1317831280380.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7703) WebAppContext should also be stopped and cleared MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121092#comment-13121092 ] Hudson commented on HADOOP-7703: -------------------------------- Integrated in Hadoop-Common-trunk-Commit #1022 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1022/]) HADOOP-7703. Improved excpetion handling of shutting down web server. (Devaraj K via Eric Yang) eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179286 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServerLifecycle.java > WebAppContext should also be stopped and cleared > ------------------------------------------------ > > Key: HADOOP-7703 > URL: https://issues.apache.org/jira/browse/HADOOP-7703 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.24.0 > Reporter: Devaraj K > Assignee: Devaraj K > Fix For: 0.24.0 > > Attachments: HADOOP-7703.patch > > > 1. If listener stop method throws any exception then the webserver stop method will not be called > {code} > public void stop() throws Exception { > listener.close(); > webServer.stop(); > } > {code} > 2. also, WebAppContext stores all the context attributes, which does not get cleared if only webServer is stopped. > so following calls are necessary to ensure clean and complete stop. > {code} > webAppContext.clearAttributes(); > webAppContext.stop(); > {code} > 3. Also the WebAppContext display name can be the name passed to HttpServer instance. > {code} > webAppContext.setDisplayName(name); > {code} > instead of > {code} > webAppContext.setDisplayName("WepAppsContext"); > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira