Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C21E7D08 for ; Wed, 12 Oct 2011 13:21:55 +0000 (UTC) Received: (qmail 59505 invoked by uid 500); 12 Oct 2011 13:21:54 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 59411 invoked by uid 500); 12 Oct 2011 13:21:54 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 59401 invoked by uid 99); 12 Oct 2011 13:21:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Oct 2011 13:21:54 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Oct 2011 13:21:53 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 299A5304E96 for ; Wed, 12 Oct 2011 13:21:13 +0000 (UTC) Date: Wed, 12 Oct 2011 13:21:13 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1661839917.4918.1318425673171.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1224681933.3684.1318393511787.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7736) Remove duplicate call of Path#normalizePath during initialization. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125828#comment-13125828 ] Hudson commented on HADOOP-7736: -------------------------------- Integrated in Hadoop-Mapreduce-trunk #858 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/858/]) HADOOP-7736. Remove duplicate Path#normalizePath call. harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1182214 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java > Remove duplicate call of Path#normalizePath during initialization. > ------------------------------------------------------------------ > > Key: HADOOP-7736 > URL: https://issues.apache.org/jira/browse/HADOOP-7736 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 0.24.0 > Reporter: Harsh J > Assignee: Harsh J > Priority: Trivial > Fix For: 0.24.0 > > Attachments: HADOOP-7736.patch > > > Found during code reading on HADOOP-6490, there seems to be an unnecessary call of {{normalizePath(...)}} being made in the constructor {{Path(Path, Path)}}. Since {{initialize(...)}} normalizes its received path string already, its unnecessary to do it to the path parameter in the constructor's call of the same. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira