Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 12 Oct 2011 03:27:11 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1574750797.3564.1318390032000.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-6490) Path.normalize should use
 StringUtils.replace in favor of String.replace
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125563#comment-13125563 ] 

Hudson commented on HADOOP-6490:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1137 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1137/])
    HADOOP-6490. Use StringUtils over String#replace in Path#normalizePath. Contributed by Uma Maheswara Rao G.

harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1182189
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java

                
> Path.normalize should use StringUtils.replace in favor of String.replace
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-6490
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6490
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-6490.patch
>
>
> in our environment, we are seeing that the JobClient is going out of memory because Path.normalizePath(String) is called several tens of thousands of times, and each time it calls "String.replace" twice.
> java.lang.String.replace compiles a regex to do the job which is very costly.
> We should use org.apache.commons.lang.StringUtils.replace which is much faster and consumes almost no extra memory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira