Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Wed, 12 Oct 2011 21:11:13 +0000 (UTC)
From: "Doug Cutting (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <1488492263.6728.1318453873356.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1779424091.53551.1313775627536.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7557) Make  IPC  header be extensible
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HADOOP-7557?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D131=
26160#comment-13126160 ]=20

Doug Cutting commented on HADOOP-7557:
--------------------------------------

> As far as smaller patch =E2=80=93 that is mostly due to auto generated fi=
les from PB.

Even without that, if something can be done without adding a dependency and=
 in less code then what real value does the dependency bring?  We don't exp=
ect to be changing this header frequently.  This is not a user extension po=
int.

> If I were to add a new field to the main header (the "hrpc" one) to indic=
ate the format of the next layer would it satisfy your concerns?

That would be better.  Then all of the protobuf-specific stuff could be bun=
dled into classes that already require protobuf.  But if there's stuff like=
 security that's used by all message encodings, why not use an encoding-ind=
ependent format in the header?  I don't see the value of supporting both a =
Writable and protobuf version of these headers.
               =20
> Make  IPC  header be extensible
> -------------------------------
>
>                 Key: HADOOP-7557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7557
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: HADOOP-7557.patch, IpcHeader.proto, ipcHeader1.patch=
, ipcHeader2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira