hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7736) Remove duplicate call of Path#normalizePath during initialization.
Date Wed, 12 Oct 2011 05:57:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125613#comment-13125613
] 

Aaron T. Myers commented on HADOOP-7736:
----------------------------------------

+1, the patch looks good to me.

I believe that according to the Hadoop bylaws, all patches require a +1 from a committer before
they can be committed. I've seen a few exceptions to that in practice, such as for trivial
documentation fixes or for back-ports from other branches. In general it's safest to just
find a committer who's willing to review it, though.
                
> Remove duplicate call of Path#normalizePath during initialization.
> ------------------------------------------------------------------
>
>                 Key: HADOOP-7736
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7736
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.24.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7736.patch
>
>
> Found during code reading on HADOOP-6490, there seems to be an unnecessary call of {{normalizePath(...)}}
being made in the constructor {{Path(Path, Path)}}. Since {{initialize(...)}} normalizes its
received path string already, its unnecessary to do it to the path parameter in the constructor's
call of the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message