hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7557) Make IPC header be extensible
Date Thu, 13 Oct 2011 02:51:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126314#comment-13126314
] 

Sanjay Radia commented on HADOOP-7557:
--------------------------------------

Some background of the current Wire protocol:
ConnectionHeader IpcConnectionHeader  RpcPayload RpcPayload RpcPayload...

The RpcPayload can be one of several kinds - basic IPC calls, writableRPC, pbRPC etc.
Note the basic IPC calls are the original Hadoop IPC calls - there are several tests that
use these. 
All the Payloads have to be of the same type. 
If there is mismatch of the RPCPayload the one will usually get a de-serializaiton error.

This jira proposes to make the IpcConnectionHeader extensible. 

I added the protocolKind to distinguish between these. 
Perhaps I should have called the field RPCEngine type instead.
It catches the unpleasant de-serialization error and reports a nicer error message.
Most protocols that have multiple instances of a layer add such "kind" field.
I believe it is wise to have this field until be remove all but one and decide that there
will never be another. 
(A fine decision to make.)
                
> Make  IPC  header be extensible
> -------------------------------
>
>                 Key: HADOOP-7557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7557
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: HADOOP-7557.patch, IpcHeader.proto, ipcHeader1.patch, ipcHeader2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message