hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7764) Allow both ACL list and global path spec filters to HttpServer
Date Tue, 25 Oct 2011 19:36:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135356#comment-13135356
] 

Jonathan Eagles commented on HADOOP-7764:
-----------------------------------------

Results run from my box.

-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.security.TestUserGroupInformation

    +1 contrib tests.  The patch passed contrib unit tests.

                
> Allow both ACL list and global path spec filters to HttpServer
> --------------------------------------------------------------
>
>                 Key: HADOOP-7764
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7764
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>            Priority: Blocker
>         Attachments: HADOOP-7764.patch, HADOOP-7764.patch
>
>
> HttpServer allows setting global path spec filters in one constructor and ACL list in
another constructor. Having both set in HttpServer is not user settable either by public API
or constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message