hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7557) Make IPC header be extensible
Date Thu, 13 Oct 2011 18:21:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126784#comment-13126784
] 

Sanjay Radia commented on HADOOP-7557:
--------------------------------------

Currently it does support multiple payload types - unfortunately a  protocolKind field was
not added when multiple payload types were added. I just added it to be consistent with the
the current implementation. We can remove it if we move to a single RPC payload type.

The code seems to make a difference between the IPC layer and the RPC layer. There are "parallel
ipc calls" that exist in the test code. My impression is that one can build different kinds
of RPC or other communications on top of IPC.
The layers and the headers are not very clean but it appears that the original purpose was
to be flexible. I think you made some of design more flexible when you added Avro support
alongside the existing writable stuff.

The separation between connection header and ipc connection header has also puzzled me - I
don't know the historical reasons. It is wise leave the initial connection header intact so
that a connection from an old client is nicely rejected. 
                
> Make  IPC  header be extensible
> -------------------------------
>
>                 Key: HADOOP-7557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7557
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: HADOOP-7557.patch, IpcHeader.proto, ipcHeader1.patch, ipcHeader2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message