hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7706) have the pre-commit checks run by hudson veto patches with System.out and System.err calls in them
Date Mon, 03 Oct 2011 09:51:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119223#comment-13119223
] 

Steve Loughran commented on HADOOP-7706:
----------------------------------------

Suresh, if we have the System.out/err calls in one place, that can be left alone. What I'd
like is no new calls to go in, to stop accidental calls going in that have been put in for
debugging. During review the warnings can be ignored; it's just an automated way of ensuring
that none go in unintentionally
                
> have the pre-commit checks run by hudson veto patches with System.out and System.err
calls in them
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7706
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Steve Loughran
>            Priority: Minor
>
> I don't know how to do this, but we ought to get checkstyle to reject System.out and
System.err calls, to stop them unintentionally getting into code. We may still need them in
some places (LogLevel, external entry points), but those main() methods could all delegate
to our own log output method that provides a single place where messages get printed

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message