hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7736) Remove duplicate call of Path#normalizePath during initialization.
Date Wed, 12 Oct 2011 04:57:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125593#comment-13125593
] 

Hadoop QA commented on HADOOP-7736:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12498704/HADOOP-7736.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/288//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/288//console

This message is automatically generated.
                
> Remove duplicate call of Path#normalizePath during initialization.
> ------------------------------------------------------------------
>
>                 Key: HADOOP-7736
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7736
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.24.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7736.patch
>
>
> Found during code reading on HADOOP-6490, there seems to be an unnecessary call of {{normalizePath(...)}}
being made in the constructor {{Path(Path, Path)}}. Since {{initialize(...)}} normalizes its
received path string already, its unnecessary to do it to the path parameter in the constructor's
call of the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message