hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7717) Move handling of concurrent client fail-overs to RetryInvocationHandler
Date Tue, 04 Oct 2011 01:30:34 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119858#comment-13119858
] 

Hadoop QA commented on HADOOP-7717:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12497583/HADOOP-7717.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/260//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/260//console

This message is automatically generated.
                
> Move handling of concurrent client fail-overs to RetryInvocationHandler
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-7717
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7717
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7717.patch
>
>
> Currently every implementation of a {{FailoverProxyProvider}} will need to perform its
own synchronization to ensure that multiple concurrent failed calls to a single client proxy
object don't result in multiple client fail over events. It would be better to put this logic
in {{RetryInvocationHandler.invoke}}.
> This is based on feedback provided by Todd in [this comment|https://issues.apache.org/jira/browse/HDFS-1973?focusedCommentId=13119567&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13119567].

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message