hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7360) FsShell does not preserve relative paths with globs
Date Thu, 27 Oct 2011 14:38:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137179#comment-13137179
] 

Daryn Sharp commented on HADOOP-7360:
-------------------------------------

Compared to earlier patches:
# {{lookupStat}} was changed to throw a {{PathNotFoundException}} with a {{Path}} string instead
of the string used to instantiate this {{PathData}}.  Since the two may be different, it defeats
part of the reason for this jira.
# Minor issue, but changing the method name of {{checkIfDirectory(...)}} to {{checkIfExists(...)}}
reduces the ability, in the context of a caller, to understand what the method does.  Perhaps
{{checkIfExistsAndIsDirectory}}?
# In {{stringToUri(...)}}:
#* Parsing a scheme out when {{slash == -1}} is allowing opaque uris, which hadoop doesn't
support, and causes a path that contains a colon to fail.
#* Parsing a scheme should use the condition {{colon == slash - 1}}, not {{colon < slash}}
to avoid attempting parse opaque uris.
# Don't the calls to {{URI.create(...)}} in {{relativize(...)}} also need to be replaced with
{{stringToUri(...)}}?

I need to look at it a bit more.
                
> FsShell does not preserve relative paths with globs
> ---------------------------------------------------
>
>                 Key: HADOOP-7360
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7360
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Kihwal Lee
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7360-2.patch, HADOOP-7360-3.patch, HADOOP-7360-4.patch, HADOOP-7360.patch,
HADOOP-7360.txt
>
>
> FsShell currently preserves relative paths that do not contain globs.  Unfortunately
the method {{fs.globStatus()}} is fully qualifying all returned paths.  This is causing inconsistent
display of paths.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message