hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7557) Make IPC header be extensible
Date Wed, 12 Oct 2011 21:11:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126160#comment-13126160
] 

Doug Cutting commented on HADOOP-7557:
--------------------------------------

> As far as smaller patch – that is mostly due to auto generated files from PB.

Even without that, if something can be done without adding a dependency and in less code then
what real value does the dependency bring?  We don't expect to be changing this header frequently.
 This is not a user extension point.

> If I were to add a new field to the main header (the "hrpc" one) to indicate the format
of the next layer would it satisfy your concerns?

That would be better.  Then all of the protobuf-specific stuff could be bundled into classes
that already require protobuf.  But if there's stuff like security that's used by all message
encodings, why not use an encoding-independent format in the header?  I don't see the value
of supporting both a Writable and protobuf version of these headers.
                
> Make  IPC  header be extensible
> -------------------------------
>
>                 Key: HADOOP-7557
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7557
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: HADOOP-7557.patch, IpcHeader.proto, ipcHeader1.patch, ipcHeader2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message