hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7424) Log an error if the topology script doesn't handle multiple args
Date Fri, 28 Oct 2011 02:25:32 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137900#comment-13137900

Eli Collins commented on HADOOP-7424:

+1  (no new test needed since we're just changing a warn to an error)
> Log an error if the topology script doesn't handle multiple args
> ----------------------------------------------------------------
>                 Key: HADOOP-7424
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7424
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Eli Collins
>              Labels: newbie
>         Attachments: HADOOP-7424.patch
> ScriptBasedMapping#resolve currently warns and returns null if it passes n arguments
to the topology script and gets back a different number of resolutions. This indicates a bug
in the topology script (or it's input) and therefore should be an error.
> {code}
> // invalid number of entries returned by the script
> LOG.warn("Script " + scriptName + " returned "
>    + Integer.toString(m.size()) + " values when "
>    + Integer.toString(names.size()) + " were expected.");
> return null;
> {code}
> There's only one place in Hadoop (FSNamesystem init) where we pass multiple arguments
to the topology script, and it only done for performance (to trigger resolution/caching of
all the hosts in the includes file on startup). So currently a topology script that doesn't
handle multiple arguments just means the initial cache population doesn't work.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message