hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7424) Log an error if the topology script doesn't handle multiple args
Date Thu, 13 Oct 2011 00:57:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126279#comment-13126279
] 

Hadoop QA commented on HADOOP-7424:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12498807/HADOOP-7424.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/292//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/292//console

This message is automatically generated.
                
> Log an error if the topology script doesn't handle multiple args
> ----------------------------------------------------------------
>
>                 Key: HADOOP-7424
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7424
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Eli Collins
>              Labels: newbie
>         Attachments: HADOOP-7424.patch
>
>
> ScriptBasedMapping#resolve currently warns and returns null if it passes n arguments
to the topology script and gets back a different number of resolutions. This indicates a bug
in the topology script (or it's input) and therefore should be an error.
> {code}
> // invalid number of entries returned by the script
> LOG.warn("Script " + scriptName + " returned "
>    + Integer.toString(m.size()) + " values when "
>    + Integer.toString(names.size()) + " were expected.");
> return null;
> {code}
> There's only one place in Hadoop (FSNamesystem init) where we pass multiple arguments
to the topology script, and it only done for performance (to trigger resolution/caching of
all the hosts in the includes file on startup). So currently a topology script that doesn't
handle multiple arguments just means the initial cache population doesn't work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message