hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7736) Remove duplicate call of Path#normalizePath during initialization.
Date Wed, 12 Oct 2011 05:49:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125610#comment-13125610

Harsh J commented on HADOOP-7736:


Well yes then, that too. Isn't this trivial enough though? I'm unclear on where all a +1 would
be required, so I'll assume its for everything :)
> Remove duplicate call of Path#normalizePath during initialization.
> ------------------------------------------------------------------
>                 Key: HADOOP-7736
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7736
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.24.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.24.0
>         Attachments: HADOOP-7736.patch
> Found during code reading on HADOOP-6490, there seems to be an unnecessary call of {{normalizePath(...)}}
being made in the constructor {{Path(Path, Path)}}. Since {{initialize(...)}} normalizes its
received path string already, its unnecessary to do it to the path parameter in the constructor's
call of the same.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message