Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDA94796A for ; Thu, 29 Sep 2011 01:17:09 +0000 (UTC) Received: (qmail 45141 invoked by uid 500); 29 Sep 2011 01:17:09 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 45101 invoked by uid 500); 29 Sep 2011 01:17:09 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 45021 invoked by uid 99); 29 Sep 2011 01:17:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Sep 2011 01:17:09 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Sep 2011 01:17:07 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A747F28E0E3 for ; Thu, 29 Sep 2011 01:16:45 +0000 (UTC) Date: Thu, 29 Sep 2011 01:16:45 +0000 (UTC) From: "Uma Maheswara Rao G (Commented) (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <675329054.6045.1317259005686.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1359718068.13331.1315008369183.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7607) Simplify the RPC proxy cleanup process MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116938#comment-13116938 ] Uma Maheswara Rao G commented on HADOOP-7607: --------------------------------------------- Make sense to me, Thanks for addressing the issue & filing Jiras. > Simplify the RPC proxy cleanup process > -------------------------------------- > > Key: HADOOP-7607 > URL: https://issues.apache.org/jira/browse/HADOOP-7607 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Affects Versions: 0.24.0 > Reporter: Aaron T. Myers > Assignee: Aaron T. Myers > Fix For: 0.24.0 > > Attachments: HADOOP-7607.2.patch, hadoop-7607.0.patch, hadoop-7607.1.patch > > > The process to clean up an RPC proxy object is to call RPC.stopProxy, which looks up the RPCEngine previously associated with the interface which that proxy object provides and calls RPCEngine.stopProxy passing in the proxy object. Every concrete implementation of RPCEngine.stopProxy then looks up the invocation handler associated with the proxy object and calls close() on that invocation handler. > This process can be simplified by cutting out the steps of looking up the previously-registered RPCEngine, and instead just having RPC.stopProxy directly look up the invocation handler for the proxy object and call close() on it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira