Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 23 Sep 2011 20:27:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <662650924.7989.1316809647377.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1823733174.7945.1316809046272.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7680) TestHardLink fails on Mac OS X,
 when gnu stat is in path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113745#comment-13113745 ] 

Hadoop QA commented on HADOOP-7680:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12496319/7680-0.23.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/230//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/230//console

This message is automatically generated.

> TestHardLink fails on Mac OS X, when gnu stat is in path
> --------------------------------------------------------
>
>                 Key: HADOOP-7680
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7680
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0, 0.23.0, 0.24.0
>         Environment: Mac OS X, where `which stat` = /opt/local/libexec/gnubin/stat
>            Reporter: Milind Bhandarkar
>            Assignee: Milind Bhandarkar
>             Fix For: 0.22.0, 0.23.0, 0.24.0
>
>         Attachments: 7680-0.22.patch, 7680-0.23.patch
>
>
> For a specific reason, `which stat` = /opt/local/libexec/gnubin/stat, on my Mac. o.a.h.f.HardLink checks for os.name, detects it's a MacOSX, and assumes that stat points to /usr/bin/stat, and uses -f%l as arguments, which fails. The upcoming patch explicitly sets stat to use /usr/bin/stat on Mac OS. In 0.22, this code is part of o.a.h.f.FileUtil, and in 0.23 and trunk it is in o.a.h.f.HardLink. Both patches forthcoming.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira