Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 674638EE3 for ; Fri, 9 Sep 2011 21:28:31 +0000 (UTC) Received: (qmail 87666 invoked by uid 500); 9 Sep 2011 21:28:31 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 87640 invoked by uid 500); 9 Sep 2011 21:28:30 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 87630 invoked by uid 99); 9 Sep 2011 21:28:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Sep 2011 21:28:30 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Sep 2011 21:28:29 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D0D1C8B824 for ; Fri, 9 Sep 2011 21:28:08 +0000 (UTC) Date: Fri, 9 Sep 2011 21:28:08 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <549231127.10048.1315603688852.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <860231771.38800.1306232087463.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7328) When a serializer class is missing, return null, not throw an NPE. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101583#comment-13101583 ] Hudson commented on HADOOP-7328: -------------------------------- Integrated in Hadoop-Hdfs-trunk-Commit #939 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/939/]) HADOOP-7328. When a serializer class is missing, return null, not throw an NPE. Contributed by Harsh J Chouraria. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1167363 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestSerializationFactory.java > When a serializer class is missing, return null, not throw an NPE. > ------------------------------------------------------------------ > > Key: HADOOP-7328 > URL: https://issues.apache.org/jira/browse/HADOOP-7328 > Project: Hadoop Common > Issue Type: Improvement > Components: io > Affects Versions: 0.20.2 > Reporter: Harsh J > Assignee: Harsh J > Labels: io, serialization > Fix For: 0.23.0, 0.24.0 > > Attachments: 0.22-HADOOP-7328.r7.diff, 0.23-HADOOP-7328.r7.diff, HADOOP-7328.r1.diff, HADOOP-7328.r2.diff, HADOOP-7328.r3.diff, HADOOP-7328.r4.diff, HADOOP-7328.r4.diff, HADOOP-7328.r5.diff, HADOOP-7328.r6.diff, HADOOP-7328.r7.diff > > > When you have a key/value class that's non Writable and you forget to attach io.serializers for the same, an NPE is thrown by the tasks with no information on why or what's missing and what led to it. I think a better exception can be thrown by SerializationFactory instead of an NPE when a class is not found accepted by any of the loaded ones. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira