Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C191832D for ; Tue, 13 Sep 2011 18:41:36 +0000 (UTC) Received: (qmail 14865 invoked by uid 500); 13 Sep 2011 18:41:35 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 14695 invoked by uid 500); 13 Sep 2011 18:41:35 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 14644 invoked by uid 99); 13 Sep 2011 18:41:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2011 18:41:34 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2011 18:41:33 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C6B93963F0 for ; Tue, 13 Sep 2011 18:41:12 +0000 (UTC) Date: Tue, 13 Sep 2011 18:41:12 +0000 (UTC) From: "Jitendra Nath Pandey (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <480998537.23429.1315939272809.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <416022159.7520.1314898329723.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7602) wordcount, sort etc on har files fails with NPE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103886#comment-13103886 ] Jitendra Nath Pandey commented on HADOOP-7602: ---------------------------------------------- Comparing the latest patch with the earliest patch that John had, I am more inclined towards the earlier approach. The point is that the methods buildDTService and buildDTAuthority in SecurityUtil are public utility methods but are not handling the invalid input well. In some cases they do return empty string host, but not consistently. I think better approach is to make that behavior consistent. In most common case when these methods are called with an invalid input, the caller code doesn't really care about what they return. For example, calling buildDTService for har file system. > wordcount, sort etc on har files fails with NPE > ----------------------------------------------- > > Key: HADOOP-7602 > URL: https://issues.apache.org/jira/browse/HADOOP-7602 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.20.205.0, 0.20.206.0 > Reporter: John George > Assignee: John George > Fix For: 0.20.205.0 > > Attachments: hadoop-7602.1.patch, hadoop-7602.2.patch, hadoop-7602.3.patch, hadoop-7602.4.patch, hadoop-7602.daryns_comment.2.patch, hadoop-7602.daryns_comment.patch, hadoop-7602.patch > > > wordcount, sort etc on har files fails with NPE@createSocketAddr(NetUtils.java:137). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira