Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 29 Sep 2011 01:08:45 +0000 (UTC)
From: "Aaron T. Myers (Commented) (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: 
 <417984522.6032.1317258525468.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <767793560.5965.1317257805561.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HADOOP-7695) RPC.stopProxy can throw unintended
 exception while logging error
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116933#comment-13116933 ] 

Aaron T. Myers commented on HADOOP-7695:
----------------------------------------

bq. In that case can i put the same patch (HADOOP-7694) here?

Note my comment in HADOOP-7607 where I said:

{quote}
The patch Uma supplied won't quite work as-is, since the {{proxy}} and {{invocationHandler}} objects can't be assumed to be non-null, but it's close.
{quote}

I'd prefer to take care of this JIRA, if you don't mind, Uma.
                
> RPC.stopProxy can throw unintended exception while logging error
> ----------------------------------------------------------------
>
>                 Key: HADOOP-7695
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7695
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 0.24.0
>
>
> {{RPC.stopProxy}} includes the following lines in case of error:
> {code}
> LOG.error("Could not get invocation handler " + invocationHandler +
>           " for proxy " + proxy + ", or invocation handler is not closeable.");
> {code}
> Trouble is, the {{proxy}} object is usually backed by {{WritableRpcEngine}}, which will fail in the event {{toString}} is called on one of its proxy objects. See HADOOP-7694 for more details on that issue. Until that's addressed, we might as well change the log message in {{RPC.stopProxy}} to not call {{toString()}} on {{proxy}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira