From common-issues-return-19489-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org Sun Sep 4 19:55:36 2011 Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 710B470EB for ; Sun, 4 Sep 2011 19:55:36 +0000 (UTC) Received: (qmail 61653 invoked by uid 500); 4 Sep 2011 19:55:35 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 61523 invoked by uid 500); 4 Sep 2011 19:55:34 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 61509 invoked by uid 99); 4 Sep 2011 19:55:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Sep 2011 19:55:33 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Sep 2011 19:55:31 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2352837A6B for ; Sun, 4 Sep 2011 19:55:10 +0000 (UTC) Date: Sun, 4 Sep 2011 19:55:10 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: common-issues@hadoop.apache.org Message-ID: <1152433352.16202.1315166110141.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1475491519.47372.1313628567220.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096934#comment-13096934 ] Aaron T. Myers commented on HADOOP-7552: ---------------------------------------- Looks like this change inadvertently broke MR trunk: https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/833/ > FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause > ------------------------------------------------------------------------ > > Key: HADOOP-7552 > URL: https://issues.apache.org/jira/browse/HADOOP-7552 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Reporter: Eli Collins > Assignee: Eli Collins > Priority: Minor > Fix For: 0.23.0 > > Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch, hadoop-7552-3.patch, hadoop-7552-3.patch > > > FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira