hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-6490) Path.normalize should use StringUtils.replace in favor of String.replace
Date Mon, 19 Sep 2011 19:54:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108091#comment-13108091
] 

Hadoop QA commented on HADOOP-6490:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12495125/HADOOP-6490.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/204//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/204//console

This message is automatically generated.

> Path.normalize should use StringUtils.replace in favor of String.replace
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-6490
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6490
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.20.1
>            Reporter: Zheng Shao
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-6490.patch
>
>
> in our environment, we are seeing that the JobClient is going out of memory because Path.normalizePath(String)
is called several tens of thousands of times, and each time it calls "String.replace" twice.
> java.lang.String.replace compiles a regex to do the job which is very costly.
> We should use org.apache.commons.lang.StringUtils.replace which is much faster and consumes
almost no extra memory.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message