hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7608) SnappyCodec check for Hadoop native lib is wrong
Date Fri, 16 Sep 2011 16:54:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106590#comment-13106590
] 

Hadoop QA commented on HADOOP-7608:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494817/HADOOP-7608.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/197//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/197//console

This message is automatically generated.

> SnappyCodec check for Hadoop native lib is wrong
> ------------------------------------------------
>
>                 Key: HADOOP-7608
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7608
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7608.patch
>
>
> Currently SnappyCodec is doing:
> {code}
>   public static boolean isNativeSnappyLoaded(Configuration conf) {
>     return LoadSnappy.isLoaded() && conf.getBoolean(
>         CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY,
>         CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_DEFAULT);
>   }
> {code}
> But the conf check is wrong as it defaults to true. Instead it should use *NativeCodeLoader.isNativeCodeLoaded()*

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message