hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7627) Improve MetricsAsserts to give more understandable output on failure
Date Mon, 12 Sep 2011 23:25:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103172#comment-13103172
] 

Hadoop QA commented on HADOOP-7627:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494141/hadoop-7627.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/166//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/166//console

This message is automatically generated.

> Improve MetricsAsserts to give more understandable output on failure
> --------------------------------------------------------------------
>
>                 Key: HADOOP-7627
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7627
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics, test
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7627.txt
>
>
> In developing a test case that uses MetricsAsserts, I had two issues:
> 1) the error output in the case that an assertion failed does not currently give any
information as to the _actual_ value of the metric
> 2) there is no way to retrieve the metric variable (eg to assert that the sum of a metric
over all DNs is equal to some value)
> This JIRA is to improve this test class to fix the above issues.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message