hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7635) RetryInvocationHandler should release underlying resources on close
Date Thu, 15 Sep 2011 06:50:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105153#comment-13105153
] 

Hadoop QA commented on HADOOP-7635:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494572/hadoop-7635.1.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    -1 release audit.  The applied patch generated 9 release audit warnings (more than the
trunk's current 0 warnings).

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/186//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/186//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/186//console

This message is automatically generated.

> RetryInvocationHandler should release underlying resources on close
> -------------------------------------------------------------------
>
>                 Key: HADOOP-7635
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7635
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 0.24.0
>
>         Attachments: hadoop-7635.0.txt, hadoop-7635.1.txt
>
>
> It is often the case that RPC invocation handlers (e.g. {{o.a.h.ipc.WritableRpcEngine.Invoker}})
are wrapped in a {{RetryInvocationHandler}} instance to handle RPC retry logic. Since {{RetryInvocationHandler}}
doesn't have any resources of its own, and is incapable of releasing the resources of the
wrapped {{InvocationHandler}}, users of {{RetryInvocationHandler}} must keep around a reference
to the underlying {{InvocationHandler}} only for the purpose of closing. For an example of
this, see {{o.a.h.hdfs.DFSClient}}, in particular the member variables {{namenode}} and {{rpcNamenode}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message