hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7706) have the pre-commit checks run by hudson veto patches with System.out and System.err calls in them
Date Fri, 30 Sep 2011 17:03:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118194#comment-13118194
] 

Suresh Srinivas commented on HADOOP-7706:
-----------------------------------------

I am not sure how this can be effectively done. System.out and System.err may be required
in some places (such as tools or main) as you suggested. Moving it to a single place, might
still result in calling of those methods and unnecessarily printed debug information.

What is you goal here? Avoid having System.err and System.out or preventing unnecessary debug
information printed resulting changed output of commands?
                
> have the pre-commit checks run by hudson veto patches with System.out and System.err
calls in them
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7706
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Steve Loughran
>            Priority: Minor
>
> I don't know how to do this, but we ought to get checkstyle to reject System.out and
System.err calls, to stop them unintentionally getting into code. We may still need them in
some places (LogLevel, external entry points), but those main() methods could all delegate
to our own log output method that provides a single place where messages get printed

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message