hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7635) RetryInvocationHandler should release underlying resources on close
Date Thu, 15 Sep 2011 18:26:10 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105571#comment-13105571
] 

Aaron T. Myers commented on HADOOP-7635:
----------------------------------------

Thanks a lot for the quick review, Todd.

I ran the full HDFS test suite last night and these were the only failures, all of which appear
to be failing on trunk:

{noformat}
org.apache.hadoop.hdfs.server.namenode.TestBackupNode
org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
org.apache.hadoop.hdfs.TestDfsOverAvroRpc
{noformat}

I'll commit this momentarily.

> RetryInvocationHandler should release underlying resources on close
> -------------------------------------------------------------------
>
>                 Key: HADOOP-7635
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7635
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 0.24.0
>
>         Attachments: hadoop-7635.0.txt, hadoop-7635.1.txt
>
>
> It is often the case that RPC invocation handlers (e.g. {{o.a.h.ipc.WritableRpcEngine.Invoker}})
are wrapped in a {{RetryInvocationHandler}} instance to handle RPC retry logic. Since {{RetryInvocationHandler}}
doesn't have any resources of its own, and is incapable of releasing the resources of the
wrapped {{InvocationHandler}}, users of {{RetryInvocationHandler}} must keep around a reference
to the underlying {{InvocationHandler}} only for the purpose of closing. For an example of
this, see {{o.a.h.hdfs.DFSClient}}, in particular the member variables {{namenode}} and {{rpcNamenode}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message