hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7358) Improve log levels when exceptions caught in RPC handler
Date Wed, 21 Sep 2011 17:34:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109690#comment-13109690
] 

Hadoop QA commented on HADOOP-7358:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12495404/HADOOP-7358.trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    -1 release audit.  The applied patch generated 1 release audit warnings (more than the
trunk's current 0 warnings).

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//console

This message is automatically generated.

> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
>                 Key: HADOOP-7358
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7358
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread
catches it and logs it before responding with the exception over the IPC channel. This is
currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged
at WARN level instead. This can help alert operators when they might be hitting some kind
of bug.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message