hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7704) JsonFactory can be created only once and used for every next request to create JsonGenerator inside JMXJsonServlet
Date Fri, 30 Sep 2011 19:47:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118332#comment-13118332
] 

Hadoop QA commented on HADOOP-7704:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12497168/HADOOP-7704.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/248//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/248//console

This message is automatically generated.
                
> JsonFactory can be created only once and used for every next request to create JsonGenerator
inside JMXJsonServlet 
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7704
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7704
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.24.0
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HADOOP-7704.patch, MAPREDUCE-3129.patch
>
>
> 1. Currently JMXJsonServlet creates JsonFactory for every http request.
> Its not efficient. 
> JsonFactory can be created only once and used for every next request to create JsonGenerator.
> 2. Also following null check is not required.
> {code}
>  if (mBeanServer == null) {
>         jg.writeStringField("result", "ERROR");
>         jg.writeStringField("message", "No MBeanServer could be found");
>         jg.close();
>         LOG.error("No MBeanServer could be found.");
>         response.setStatus(HttpServletResponse.SC_NOT_FOUND);
>         return;
>  }
> {code}
> Because ManagementFactory.getPlatformMBeanServer(); will not return null.
> 3. Move the following code to finally so that any exception should not cause skipping
of close method on JsonGenerator
> {code}
> jg.close();
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message