hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-4905) static initializers for default config files duplicate code
Date Tue, 27 Sep 2011 15:37:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115573#comment-13115573

Uma Maheswara Rao G commented on HADOOP-4905:

Thanks Doug for the clarification!

If that is the case, we can move it to closure, because your expectation has been handled
in trunk code.
I can see the 'Configuration.addDefaultResource' references only in HdfsConfigurations.java
file. All other places, just invoked the init API from HdfsConfigurations class.

> static initializers for default config files duplicate code
> -----------------------------------------------------------
>                 Key: HADOOP-4905
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4905
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.20.0
>            Reporter: Doug Cutting
>            Priority: Minor
>              Labels: newbie
> The default config files are loaded by static initializers.  The code in these initializers
is two lines that contains string literals.  This is fragile and duplicated code.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message