hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7598) smart-apply-patch.sh does not handle patching from a sub directory correctly.
Date Mon, 05 Sep 2011 20:00:10 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097301#comment-13097301
] 

Tom White commented on HADOOP-7598:
-----------------------------------

This looks good to me. I tried it out with a few patches at various levels and it worked.
Which cases were failing for you before?

Also, there is some similar logic in test-patch for determining which modules changed, so
only those tests are run. However, I don't think we need to do that with the current nested
structure, since Jenkins runs at the hadoop-common-project, hadoop-hdfs-project, or hadoop-mapreduce-project
level and should run all the tests under that level. I've filed HADOOP-7612 to fix that.


> smart-apply-patch.sh does not handle patching from a sub directory correctly.
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-7598
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7598
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7598-v1.patch, HADOOP-7598-v2.patch, HADOOP-7598-v3.patch,
HADOOP-7598-v4.patch
>
>
> smart-apply-patch.sh does not apply valid patches from trunk, or from git like it was
designed to do in some situations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message