hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7446) Implement CRC32C native code using SSE4.2 instructions
Date Tue, 06 Sep 2011 16:43:10 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098150#comment-13098150
] 

Hadoop QA commented on HADOOP-7446:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12493172/pipelined-crc.patch.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/140//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/140//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/140//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/140//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/140//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth-examples.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/140//console

This message is automatically generated.

> Implement CRC32C native code using SSE4.2 instructions
> ------------------------------------------------------
>
>                 Key: HADOOP-7446
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7446
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.23.0
>
>         Attachments: crc-pipeline-fix.txt, hadoop-7446.txt, hadoop-7446.txt, hadoop-7446.txt,
pipelined-crc.patch.txt, pipelined_on_todds_patch.txt, pipelined_with_todds_patch.txt
>
>
> Once HADOOP-7445 is implemented, we can get further performance improvements by implementing
CRC32C using the hardware support available in SSE4.2. This support should be dynamically
enabled based on CPU feature flags, and of course should be ifdeffed properly so that it doesn't
break the build on architectures/platforms where it's not available.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message