hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-7627) Improve MetricsAsserts to give more understandable output on failure
Date Mon, 12 Sep 2011 22:41:09 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HADOOP-7627:
--------------------------------

    Attachment: hadoop-7627.txt

Attached patch fixes the above example to:

java.lang.AssertionError: Bad value for metric FilesRenamed expected:<2> but was:<1>

for the incorrect metric case, and:

java.lang.AssertionError: Expected exactly one metric for name FilesRenamedXXXX expected:<1>
but was:<0>

for the wrong metric name case.

I tested that TestNameNodeMetrics passes with this change.

> Improve MetricsAsserts to give more understandable output on failure
> --------------------------------------------------------------------
>
>                 Key: HADOOP-7627
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7627
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics, test
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-7627.txt
>
>
> In developing a test case that uses MetricsAsserts, I had two issues:
> 1) the error output in the case that an assertion failed does not currently give any
information as to the _actual_ value of the metric
> 2) there is no way to retrieve the metric variable (eg to assert that the sum of a metric
over all DNs is equal to some value)
> This JIRA is to improve this test class to fix the above issues.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message