hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7552) FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
Date Thu, 01 Sep 2011 07:08:10 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095155#comment-13095155
] 

Hadoop QA commented on HADOOP-7552:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12492569/hadoop-7552-3.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 46 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/117//console

This message is automatically generated.

> FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-7552
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7552
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7552-1.patch, hadoop-7552-2.patch, hadoop-7552-3.patch
>
>
> FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its
throws clause. Having it listed makes it easy to think you'll get an IOException eg trying
to delete a non-existant file or on an IO error accessing the local file, but you don't.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message