hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7635) RetryInvocationHandler should release underlying resources on close
Date Wed, 14 Sep 2011 23:48:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105011#comment-13105011
] 

Hadoop QA commented on HADOOP-7635:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494535/hadoop-7635.0.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/185//console

This message is automatically generated.

> RetryInvocationHandler should release underlying resources on close
> -------------------------------------------------------------------
>
>                 Key: HADOOP-7635
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7635
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>             Fix For: 0.24.0
>
>         Attachments: hadoop-7635.0.txt
>
>
> It is often the case that RPC invocation handlers (e.g. {{o.a.h.ipc.WritableRpcEngine.Invoker}})
are wrapped in a {{RetryInvocationHandler}} instance to handle RPC retry logic. Since {{RetryInvocationHandler}}
doesn't have any resources of its own, and is incapable of releasing the resources of the
wrapped {{InvocationHandler}}, users of {{RetryInvocationHandler}} must keep around a reference
to the underlying {{InvocationHandler}} only for the purpose of closing. For an example of
this, see {{o.a.h.hdfs.DFSClient}}, in particular the member variables {{namenode}} and {{rpcNamenode}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message