hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7608) SnappyCodec check for Hadoop native lib is wrong
Date Sat, 17 Sep 2011 13:21:10 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107126#comment-13107126
] 

Hudson commented on HADOOP-7608:
--------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #9 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/9/])
    HADOOP-7608. SnappyCodec check for Hadoop native lib is wrong. Contributed by Alejandro
Abdelnur.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171717
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/SnappyCodec.java


> SnappyCodec check for Hadoop native lib is wrong
> ------------------------------------------------
>
>                 Key: HADOOP-7608
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7608
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7608.patch
>
>
> Currently SnappyCodec is doing:
> {code}
>   public static boolean isNativeSnappyLoaded(Configuration conf) {
>     return LoadSnappy.isLoaded() && conf.getBoolean(
>         CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY,
>         CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_DEFAULT);
>   }
> {code}
> But the conf check is wrong as it defaults to true. Instead it should use *NativeCodeLoader.isNativeCodeLoaded()*

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message