hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7035) Document incompatible API changes between releases
Date Fri, 30 Sep 2011 00:23:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117776#comment-13117776
] 

Tom White commented on HADOOP-7035:
-----------------------------------

> 1. Is it possible that the tool needs to be applied the other way around, that is having
0.22 as the base and Tested version being 0.21?

The method signature changed, which is reported as the method being removed. In 0.21 it was
{code}
protected SequenceFile.Reader createDataFileReader(FileSystem fs,
    Path dataFile, Configuration conf)
{code}

And in 0.22 it is

{code}
protected SequenceFile.Reader 
    createDataFileReader(Path dataFile, Configuration conf,
                         SequenceFile.Reader.Option... options)
{code}

> 2. Did you run the tool against MR only? Hard to believe there were no API changes in
HDFS and common.

I ran it against all three. HDFS is marked as @Private, so it won't show up in the report.

> 3. What is the final goal of this jira. Is it to identify incompatible changes and make
a patch for site with the release notes?

Yes, including it in the release notes would be a good start.

> If so we can filter out non public changes from the reports generated by SigTest and
probably those that do not belong to public APIs in turns of Hadoop annotations, if it makes
sense.

The script already uses the annotations to restrict the changes to the public API.
                
> Document incompatible API changes between releases
> --------------------------------------------------
>
>                 Key: HADOOP-7035
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7035
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: apicheck-hadoop-0.20.203.0-0.20.204.0.txt, apicheck-hadoop-0.21.0-0.22.0-SNAPSHOT.txt,
jdiff-with-previous-release.sh, jdiff-with-previous-release.sh
>
>
> We can use JDiff to generate a list of incompatible changes for each release. See https://issues.apache.org/jira/browse/HADOOP-6668?focusedCommentId=12860017&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12860017

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message