hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7598) smart-apply-patch.sh does not handle patching from a sub directory correctly.
Date Thu, 01 Sep 2011 21:24:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095612#comment-13095612
] 

Todd Lipcon commented on HADOOP-7598:
-------------------------------------

At least on my system, the --dry-run does output that even if it fails:

{noformat}
todd@todd-w510:/tmp$ patch --dry-run < ~/HBASE-3954.patch  2>&1 | grep '^patching
file'
patching file TestHFile.java
patching file AbstractBlockIndex.java
patching file HFile.java
patching file SimpleBlockIndex.java
{noformat}

(of course none of those files exist in /tmp, where I ran the patch command)

> smart-apply-patch.sh does not handle patching from a sub directory correctly.
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-7598
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7598
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HADOOP-7598-v1.patch, HADOOP-7598-v2.patch, HADOOP-7598-v3.patch
>
>
> smart-apply-patch.sh does not apply valid patches from trunk, or from git like it was
designed to do in some situations.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message