hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7556) TaskLogAppender does not check if closed before flushing
Date Fri, 19 Aug 2011 04:14:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087512#comment-13087512
] 

Hadoop QA commented on HADOOP-7556:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12490914/HADDOP-7556.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/53//console

This message is automatically generated.

> TaskLogAppender does not check if closed before flushing
> --------------------------------------------------------
>
>                 Key: HADOOP-7556
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7556
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.20.203.0
>            Reporter: Aaron Morton
>            Priority: Minor
>         Attachments: HADDOP-7556.diff
>
>
> For background see http://groups.google.com/group/brisk-users/browse_thread/thread/3a18f4679673bea8
> http://mail-archives.apache.org/mod_mbox/hadoop-common-user/201108.mbox/%3C4E370C97-1541-4FDA-8456-1067DDDC4D77@thelastpickle.com%3E
> Cassandra is using a log4j PropertyConfigurator which is closing all existing appenders.
After a task has completed the TaskLogAppender.flush() is called and it tries to flush without
checking if the writer has been closed. I'll upload a patch to check if the writer is closed,
and log and silently fail if it is. 
> The real problem is the log4j config collision, we're looking to different log4j LoggerRepositories
for that. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message