hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7531) Add servlet util methods for handling paths in requests
Date Wed, 10 Aug 2011 13:55:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082346#comment-13082346
] 

Daryn Sharp commented on HADOOP-7531:
-------------------------------------

bq. And we wouldn't let someone check that in.. =)

I'm worried because it's a latent land-mine.  Over 20 years I've debugged so many "it'll never
happen" bugs that I strongly adhere to Murphy's Law.  Someday the charset will be changed,
either in error or with legit purpose, or an external jar will fiddle with the charset, or
a deployment env will use an incompatible charset, etc.  When that day arrives, some poor
developer will spend too much time debugging why the web page acts goofy instead of immediately
seeing an invalid charset exception.

Perhaps the safest way is to not catch the exception and use {{URIUtil.encodeXXX(String, "UTF-8")}}?

> Add servlet util methods for handling paths in requests 
> --------------------------------------------------------
>
>                 Key: HADOOP-7531
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7531
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.23.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7531-1.patch, hadoop-7531-2.patch
>
>
> Common side of HDFS-2235.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message