hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-7492) Add automated test for the RPC IP addr change detection and reconnect feature
Date Fri, 19 Aug 2011 22:47:27 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-7492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088041#comment-13088041
] 

Suresh Srinivas commented on HADOOP-7492:
-----------------------------------------

Comments:
# Can you please add in testAddrChange() method comments what the behavior at the client that
is being tested, instead of terse, "address change detection by the RPC client". Description
that covers, RPC client on seeing connection failure, re-resolves the address and connects
to the new address would be good. This will make the test easy for others to understand.
# Can you please set in conf, "ipc.client.connect.max.retries" to 10 (even though default
is 10, which might change) to ensure more than two attempts are made for the test to pass.
done in two retries? Also along with whenNew could you add a comment that return old address
for two retry attempts and resolve to a new address in the third attempt?
# Nit: LocaTestServer#call() has indentation issues
# Nit: Please add to class javadoc "Unit tests for RPC addr change detection in {@link Client}
# Nit: typo attemp 


> Add automated test for the RPC IP addr change detection and reconnect feature
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-7492
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7492
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: ipc
>    Affects Versions: 0.23.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Blocker
>             Fix For: 0.23.0
>
>         Attachments: TestRPCAddressChange.patch
>
>
> Make sure HADOOP-7472 is forward ported to 0.23 by adding an automated test.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message