hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-7493) [HDFS-362] Provide ShortWritable class in hadoop.
Date Wed, 17 Aug 2011 08:56:27 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-7493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uma Maheswara Rao G updated HADOOP-7493:
----------------------------------------

    Status: Patch Available  (was: Open)

Hi Nicholas,

Thanks a lot for taking a look and also thanks for the good comments.

{quote}There is a warning: WritableComparable is a raw type. References to generic type WritableComparable<T>
should be parameterized
{quote}
 Fixed.
 Javadoc example class need to correct in WritableComparable interface.
 I am planning to file other issue for correcting all other writables. What do you say?

{quote}Why converting shorts to ints? 
+      int thisValue = (short) readUnsignedShort(b1, s1);
+      int thatValue = (short) readUnsignedShort(b2, s2);
{quote}
  Anyway return type will be converted to int right. So, i put them as ints.
 Changed to shorts

{quote}Please add @Override tags.{quote}
   done.

{quote}There are many tailing spaces in the license header. Please remove them.
 corrected.{quote}
  My observation is that, hadoop coding formatter is not removing the training spaces.
  Is it the same case for you? if yes, shall we file one JIRA for correcting this?
  Because i copied that header from some other class (i dont remember exactly), looks that
file also might have the same. If we have capture this rule in coding formatter itself, we
will not miss this kind of small style issues.

--Thanks


> [HDFS-362] Provide ShortWritable class in hadoop.
> -------------------------------------------------
>
>                 Key: HADOOP-7493
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7493
>             Project: Hadoop Common
>          Issue Type: New Feature
>    Affects Versions: 0.23.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HADOOP-7493.1.patch, HADOOP-7493.3.patch, HADOOP-7953.2.patch
>
>
> As part of HDFS-362, Provide the ShortWritable class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message